|
|
HRD Logbook IOTA Island ID.pdf (262,320 bytes) |
|
|
The Logbook app maintains about 120 fields for each record. These fields are identified by an index -- a number that identifies the field uniquely within the row. For example, "mode" is field index #46. Since there are about 120 fields (122, exactly), the indexes range from 0 to 121. If we want to do something to each field (like format it for export to an ADIF file) we simply loop over the fields from 0 to 121 (inclusive) and process each one. This works great; the IOTA_ISLAND field is index number 113, falls inside that range, and it's fine. Indexplicably, a handful of fields are outside of the numeric range [0..121], and aren't handled by such a simple loop. They're not handled by the ADIF Export code and the XML export code, alike -- which means this bug exists for XML imports and exports, too. These fields have indexes like 8002 and 9001. The IOTA Name that's missing in this bug is 9004. We can't simply loop over the values, because we'd be looping over several thousand values (from 122 to 7999; then from 8004 to 8999) that are unused. To fix this issue safetly, I have to come to understand why this arrangement exists and circumvent it appropriately. It would make sense to fix the problem throughout the application. Otherwise, the fix for this specific issue would just add special cases to special cases, and that's why code starts to smell badly. |
|
|
See the loop in ADIFCreate.cpp in the CADifCreate::AddEntry() method. The loop in XMLSaveToFile.cpp is really in CLogbookQSORecordset::GetFieldsXML(), called from CXMLSaveToFile::Save() |
|
|
A fix for this issue is staged on this shelf: https://hrdsoftware.visualstudio.com/HRD/_versionControl/shelveset?ss=Fix%20for%20Mantis%202026%3Bmikeblas%40msn.com |
|
|
This checkin has been made to resovle this issue: https://hrdsoftware.visualstudio.com/HRD/_versionControl/changeset/3986 Note that it's possible to write an integer to identify a particular island. This is different than the AA-NNN code; just a plain number. The ADIF spec calls this field "IOTA_ISLAND_ID". That work is _not_ done with this checkin. This checkin _does_ enable the round-trip of the island name as an application-specific string. A new item is opened to track the IOTA_ISLAND_ID field. |
|
|
Followed the steps to reproduce, and the exported contact was successfully imported into a new database with the correct IOTA field value of OC-006 and the app_hamradiodeluxe_island field value of Tasmania preserved and displayed correctly. Refer attachments. Fixed. Test Mantis #0002026.ADI (1,465 bytes)
Test Mantis #0002026.jpg (34,898 bytes) |
- Anonymous
