View Issue Details

IDProjectCategoryView StatusLast Update
00020911 - BacklogBugpublic2019-06-15 11:30
ReporterK7ZCZAssigned ToK7ZCZ 
PrioritynormalSeveritymajorReproducibilityalways
Status assignedResolutionopen 
PlatformIntel i7-5960XOSWindows 10 Professional x64OS Version1703
Summary0002091: ODBC API calls flagged by Analyzer
Description
In running the C++ code analyzer on the Logbook code, I find several errors in ODBC API calls that, to me, indicate the code could never possibly work as intended.

One common issue is the use of lists of strings which are terminated by two nuls:

"String1\0String2\0\0"

In a few places, such strings are passed to standard C library or MFC calls, and those APIs don't handle the list of strings; they dutifully stop at the first nul terminator.

There are other issues, but these seem to be the most prevalent.
Steps To ReproduceCode like this, for example:

    try
    {
        BOOL bResult = FALSE;
        CString strCmd;
        TCHAR szCommand[1024] = _T("");
        TCHAR szDriver[1024] = _T("");

        strCmd.Format(_T("DSN=Test\0DBQ=%s\0\0"), m_strFilename);
TagsNo tags attached.
ModuleLogbook
Sub-ModuleGeneral
Testing

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2017-07-03 15:49 K7ZCZ New Issue
2017-07-03 15:49 K7ZCZ Status new => assigned
2017-07-03 15:49 K7ZCZ Assigned To => ERIK
2017-09-18 00:14 WA9PIE Project 3 - Current Dev List => 2 - Next Dev List (Holding Area)
2019-02-27 19:03 WA9PIE Assigned To ERIK => K7ZCZ
2019-06-15 11:30 WA9PIE Project 2 - Next Dev List (Holding Area) => 1 - Backlog