View Issue Details

IDProjectCategoryView StatusLast Update
00028153 - Current Dev ListBugpublic2018-08-22 15:58
ReporterK7ZCZAssigned To 
PrioritynormalSeveritycrashReproducibilityhave not tried
Status newResolutionopen 
Product Version6.4.0.840 
Target VersionFixed in Version 
Summary0002815: Logbook: Crashes when painting first column of item in Awards view
DescriptionI don't have a specific repro for this, as it was found by analyzing dumps reported to the Microsoft Dev Center Dashboard. This crash represents about 2% of the reported crashes in the Logbook.

The callstack is attached, given against the 840 build symbols. The crash happens when cloning a string from the awards definition in order to draw the first column of names in the view.

            CAward2Definition *pDefn = pAO->GetAwardsDef();
            if( !pDefn->m_astrAddCommands.IsEmpty() )
            {
                for( int i = 0; i < pDefn->m_astrAddCommands.GetCount(); ++i )
                {
                    CString strLine = pDefn->m_astrAddCommands.GetAt(i);     // line 1125
                    int iFind = strLine.Find(' ');
                    if( iFind >= 0 )



I haven't yet dug into the disassembly to see if it's possible that pDefn is actually NULL. Maybe it can't be, if it was previously dereferenced to get the count. Or, maybe the test for the empty array was optimized with the invariant of the for() loop, since they're similar calls and inline functions are available.


TagsNo tags attached.
ModuleLogbook
Sub-ModuleAwards
TestingNot Started

Activities

K7ZCZ

2018-07-24 19:56

administrator  

Mantis2815Stack.xlsx (14,840 bytes)

K7ZCZ

2018-08-22 14:15

administrator   ~0005992

Reports of the same crash are coming in against Build 846.

Mantis2815Stack Build 846.xlsx (11,434 bytes)

K7ZCZ

2018-08-22 15:33

administrator   ~0005993

pDefn isn't null; it seems more likely that the pDefn object is bogus or uninitialized. I did a deeper stack trace on the 846 build, and I notice that the very bottom of the stack trace is activating the Awards window from a CXTPTabClient window -- but that gets routed to a CXTPCalendarCaptionBar, which seems pretty weird.

I can't seem to repro that part of the call stack, so I can't yet guess how the user is interacting with the app when this crash occurs.

K7ZCZ

2018-08-22 15:58

administrator   ~0005994

A touch of refactoring -- just collect about 50 lines of copy-pasta in the Awards2View implementation.
https://hrdsoftware.visualstudio.com/HRD/_versionControl/changeset/4297

Nothing that fixes this issue, tho :(

Issue History

Date Modified Username Field Change
2018-07-24 19:55 K7ZCZ New Issue
2018-07-24 19:55 K7ZCZ Description Updated View Revisions
2018-07-24 19:55 K7ZCZ Module (select) => Logbook
2018-07-24 19:55 K7ZCZ Sub-Module (select) => Awards
2018-07-24 19:56 K7ZCZ File Added: Mantis2815Stack.xlsx
2018-08-22 14:15 K7ZCZ File Added: Mantis2815Stack Build 846.xlsx
2018-08-22 14:15 K7ZCZ Note Added: 0005992
2018-08-22 15:33 K7ZCZ Note Added: 0005993
2018-08-22 15:58 K7ZCZ Note Added: 0005994