View Issue Details

IDProjectCategoryView StatusLast Update
00029822 - Next Dev List (Holding Area)Maintenancepublic2020-07-02 02:11
ReporterK7ZCZAssigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
Status newResolutionopen 
Summary0002982: CXMLMgrSDK is almost-unused reimplementation of CXMLMgr
The applications share the CXMLMgr class to read and write XML-formatted data.

The CMigrateDlg in the Setup2.DLL library avoids the CXMLMgr class and uses, instead, a class named CXMLMgrSDK. This class is reimplemented from CXMLMgr, but avoids using MFC (CString, in particular) and any C-runtime library routines. It reimplements several CRTL routines, in fact.

Re-implementations of low-level functions, and of CXMLMgr itself, are unjustified and should be removed. We're better off with a single CXMLMgr implementation so we can fix bugs and add features in one single place.

TagsNo tags attached.
TestingNot Started


related to 0003254 new 2 - Next Dev List (Holding Area) CXMLMgr (and CXMLMgrSDK) seem like they leak objects 



2018-12-15 10:17

developer   ~0006655

This checkin scopes a couple of global, static helper functions for XML/HTML formatting into the CXMLMgr class. Tight scoping is a tenet of good C++ programming:

Scoping these functions immediately revealed that some code which shoudl be using CXMLMgr (from HRDCommon) was instead depending on both CXMLMgr and CXMLMgrSDK (from Setup2). That dependency is rectified in the same checkin. Remedying this dependency further isolates the CXMLMgrSDK code in preparation for removal.

Issue History

Date Modified Username Field Change
2018-12-11 12:21 K7ZCZ New Issue
2018-12-15 10:17 K7ZCZ Note Added: 0006655
2019-10-05 10:37 K7ZCZ Relationship added related to 0003254
2020-07-02 02:11 WA9PIE Project 3 - Current Dev List => 2 - Next Dev List (Holding Area)