View Issue Details

IDProjectCategoryView StatusLast Update
00033423 - Current Dev ListBugpublic2019-06-23 17:04
ReporterK7ZCZAssigned Todoug 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0003342: LicenseValidator constructor uses hard-coded product version number
DescriptionI noticed this code in the constructor for LicenseValidator (in LicenseValidator.cpp)

            license->DefineProduct (3, _bstr_t("HRD Software"), 6, 5, _bstr_t(""), _bstr_t("{f3712df5-2e48-4152-9dd2-a2bdd6ef2062}"));


I'm not sure what these numbers are used for, but it looks like "6, 5" is for the version number of the product. If so, to avoid surprises in the future, it seems like we should fix this code to use the macros defined in the hrdver.h header.
TagsNo tags attached.
ModuleSW License Mgmt
Sub-ModuleSW License Client
TestingNot Started

Activities

doug

2019-06-12 16:16

developer   ~0008057

I think if we change this it will not be backwards compatible with existing keys that exist in QLM. I will test it out, but I might recommend not changing automatically. If so I will just change the 6 and 5 to a better named #define for the min version key.

WA9PIE

2019-06-22 11:22

administrator   ~0008170

Sounds like we should discuss this to that we all understand it.

This doesn't look like a "show-stopper". It looks like something we could change at a later date. As such, I may remove its relationship to 1990.

Issue History

Date Modified Username Field Change
2019-06-11 08:32 K7ZCZ New Issue
2019-06-12 16:16 doug Note Added: 0008057
2019-06-13 14:47 WA9PIE Module QLM => SW License Mgmt
2019-06-13 15:32 WA9PIE Sub-Module QLM Client => SW License Client
2019-06-15 23:21 WA9PIE Assigned To => doug
2019-06-15 23:21 WA9PIE Status new => assigned
2019-06-22 11:22 WA9PIE Note Added: 0008170
2019-06-23 17:04 doug Status assigned => resolved
2019-06-23 17:04 doug Resolution open => fixed