View Issue Details

IDProjectCategoryView StatusLast Update
00033433 - Current Dev ListBugpublic2019-06-15 22:45
ReporterK7ZCZAssigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0003343: LicenseValidator constructor catches all exceptions, then rethrows
DescriptionI found this cdoe in the constructor for LicenseValidator (in LicenseValidator.cpp)

    catch (...)
    {
        throw;
    }


There's really no reason for this code to exist. If an exception is thrown, it should be handled by trapping a specific exception type. Catching all exception types with "..." is an anti-pattern. Worse, this code catches all exceptions, then simply re-throws them; there's no conceivable reason for this.

Further, if there is an exception, I think this code leaks because the try block includes at least one statement that allocates resources without a path to free them during exception handling.

TagsNo tags attached.
ModuleSW License Mgmt
Sub-ModuleSW License Client
TestingNot Started

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-06-11 08:33 K7ZCZ New Issue
2019-06-15 10:44 WA9PIE Description Updated View Revisions
2019-06-15 10:44 WA9PIE Module QLM => SW License Mgmt
2019-06-15 10:44 WA9PIE Sub-Module QLM Client => SW License Client